Ve197 ошибка синтаксиса в скрипте

• 
• Forum
• Mainline — Trainz Discussion
• General Trainz
• error with uploaded reefers in script

1. June 22nd, 2022, 09:25 PM

   #1

   error with uploaded reefers in script
   

   not sure how to fix this. thanks.

   An Error Occured with <kuid:327871:100830> Rock Island 40ft Reefer V1 #
   <kuid:327871:100830> : VE197: Syntax error in script ‘reefer3lodi.gs’ for asset <kuid:327871:100830> «Rock Island 40ft Reefer V1 #»
   <kuid:327871:100830> : VE267: reefer3lodi.gs(397) : member MESSAGE_BROADCAST is obsolete in object Router.

   file to big to show all of it

   but here is the part that is wroung? maybe

   Message msg;
   int m_target = Router.MESSAGE_BROADCAST;

   cloned from 40ft Reefer Illinois Central MDT #d
   <kuid2:56063:100656:2>

   Modeling Ho scale on the cheap

   GT 730 8 Meg

   ---

2. June 22nd, 2022, 11:35 PM

   #2

   
   

   The script uses obsolete functions.

   the script APIs themselves say:
   // Obsolete, do not use.
   // Message broadcasting causes every script object to be sent a message. This
   // is very inefficient, as most nodes won’t want the message, and unneccessary,
   // as Sniff can be used to be notified of specific messages on objects.
   // Note that in future versions scripts attempting to post or receive
   // broadcast messages may trigger script exceptions and/or error logs.
   public obsolete define int MESSAGE_BROADCAST = 0;

   Visit the wiki page here for more info on fixing obsolete scripts:
   https://online.ts2009.com/mediaWiki/…ript_functions

   ---

3. June 23rd, 2022, 08:05 AM

   #3

   
   

   Originally Posted by Tony_Hilliam
   

   The script uses obsolete functions.

   the script APIs themselves say:
   // Obsolete, do not use.
   // Message broadcasting causes every script object to be sent a message. This
   // is very inefficient, as most nodes won’t want the message, and unneccessary,
   // as Sniff can be used to be notified of specific messages on objects.
   // Note that in future versions scripts attempting to post or receive
   // broadcast messages may trigger script exceptions and/or error logs.
   public obsolete define int MESSAGE_BROADCAST = 0;

   Visit the wiki page here for more info on fixing obsolete scripts:
   https://online.ts2009.com/mediaWiki/…ript_functions

   Is it time to look at scripting and see if we can come up with a number of either certified scripts or standard scripts that can be used by content creators and I don’t mean complex ones that do many things. The broadcast comment is of interest as many of the coupling scripts for UK assets I believe used it so what will replace those scripts?

   Thanks

   Cheerio John

   ---

4. June 23rd, 2022, 11:05 AM

   #4

   
   

   Originally Posted by johnwhelan
   

   Is it time to look at scripting and see if we can come up with a number of either certified scripts or standard scripts that can be used by content creators and I don’t mean complex ones that do many things. The broadcast comment is of interest as many of the coupling scripts for UK assets I believe used it so what will replace those scripts?

   Thanks

   Cheerio John

   In another thread Tony has already put out the call to hire some part time workers with Trainz scripting experience to start updating older and broken scripts on the DLS.

   For the ‘reefer3lodi.gs’ script, I’m in the process of updating a version of that script for Majekear. The new version will be maintained in a library asset so it can be modified and updated very easily. The older assets using older variations of the script have their own copy of the script included in each asset. So updating each individual script is a nightmare. The reason I suggested to Majekear to switch to a central library holding all the updated scripts and use the «script-include-table» container in the config as required so the asset has access to script(s) as required, is to avoid problems like this in the future.

   <kuid:327871:100830> : VE267: reefer3lodi.gs(397) : member MESSAGE_BROADCAST is obsolete in object Router. — I didn’t write this section of the above script. It was part of the script I was given to fix — way back in TRS06 IIRC. So it’s been around 15 years or so. The part throwing the error controls the visual effects when coupling cars.

   Technically I don’t have clear permission to change this part of the script due to possible copyright infringements but if the original author of that code wants to object he is free to do so. In the mean time I’ll change this in the new version of the script. This will only eliminate the error on new versions of the cars.

   That’s the easy part. To fix existing content requires editing the existing script. But has to be done on each and every asset using this or a similar script.

   Bob Pearson

   Last edited by RPearson; June 23rd, 2022 at 11:36 AM.

   TRAINZ-UTC-TRS04-TRS06-TC1&2-TC3-TS09-TS10-TS12-TANE(TEG)-TMR17-TRS19-TRS22
   Member since 6-14-2002

   ---

5. June 23rd, 2022, 02:23 PM

   #5

   
   

   Much like Andrea did with the JAG scripts. I like the approach but it means somewhere we need to document it for content creators and those who reskin.

   Cheerio John

   ---

6. June 23rd, 2022, 05:58 PM

   #6

   
   

   Originally Posted by johnwhelan
   

   Much like Andrea did with the JAG scripts. I like the approach but it means somewhere we need to document it for content creators and those who reskin.

   Cheerio John

   Not sure what and where it has to be documented as a new script will be used with the any new cars that are uploaded. Reskinners using the new cars will use the new script unless they replace it in the configs with their own or different one. For old cars that are reskinned the reskinner is on the hook to verify his upload meets current standards.

   As a follow on I have looked at the code (see below) and I’m a bit confused because as far as I can see the script doesn’t actually use the Router.MESSAGE_BROADCAST member it assigns to the int variable m_target. NO MESSAGES ARE SENT using this as a destination.

   Is the new check only testing for presence of «Router.MESSAGE_BROADCAST»? This script does not and cannot as coded broadcast messages to every node in the Router.

   You only need to comment out or just delete line 397, «int m_target = Router.MESSAGE_BROADCAST;», to clear the error flagged by the compiler. I’ve already deleted it in the new version of the script I’m working on. Actually, I did it some time ago since Rene and I have both had some starts, stops and long delays with this update — real life and frustrations with Trainz occasionally getting in the way.

   Code:

     thread void CarMonitor(void) {
   
       Message msg;
       int m_target = Router.MESSAGE_BROADCAST; <-- change this line to //int m_target = Router.MESSAGE_BROADCAST; 
                                                     OR DELETE IT to clear error
   
       while (status != CAR_DERAILED) {
         if (status and DoUpdate) {
           DoUpdate = 0;
           DecoupleHoses(status, GetDirectionRelativeToTrain());
           UpdateGear();
         }
         wait() {
           on "Vehicle", "BadCouple", msg: {
           }
           on "Vehicle", "Coupled", msg: {
           }
           on "Vehicle", "Decoupled", msg: {
           }
           on "Vehicle", "Derailed", msg: {
             if (msg.src == me) { status = CAR_DERAILED; break; }
           }
           on "World", "ModuleInit": {
             status = CarCheck();
             SetGear(status, GetDirectionRelativeToTrain());
           }
         }
         status = CarCheck();
       }
     }

   Bob Pearson

   TRAINZ-UTC-TRS04-TRS06-TC1&2-TC3-TS09-TS10-TS12-TANE(TEG)-TMR17-TRS19-TRS22
   Member since 6-14-2002

   ---

7. June 23rd, 2022, 06:14 PM

   #7

   
   

   Originally Posted by RPearson
   

   Not sure what and where it has to be documented as a new script will be used with the any new cars that are uploaded. Reskinners using the new cars will use the new script unless they replace it in the configs with their own or different one. For old cars that are reskinned the reskinner is on the hook to verify his upload meets current standards.

   As a follow on I have looked at the code (see below) and I’m a bit confused because as far as I can see the script doesn’t actually use the Router.MESSAGE_BROADCAST member it assigns to the int variable m_target. NO MESSAGES ARE SENT using this as a destination.

   Is the new check only testing for presence of «Router.MESSAGE_BROADCAST»? This script does not and cannot as coded broadcast messages to every node in the Router.

   You only need to comment out or just delete line 397, «int m_target = Router.MESSAGE_BROADCAST;», to clear the error flagged by the compiler. I’ve already deleted it in the new version of the script I’m working on. Actually, I did it some time ago since Rene and I have both had some starts, stops and long delays with this update — real life and frustrations with Trainz occasionally getting in the way.

   Code:

     thread void CarMonitor(void) {
   
       Message msg;
       int m_target = Router.MESSAGE_BROADCAST; <-- change this line to //int m_target = Router.MESSAGE_BROADCAST; 
                                                     OR DELETE IT to clear error
   
       while (status != CAR_DERAILED) {
         if (status and DoUpdate) {
           DoUpdate = 0;
           DecoupleHoses(status, GetDirectionRelativeToTrain());
           UpdateGear();
         }
         wait() {
           on "Vehicle", "BadCouple", msg: {
           }
           on "Vehicle", "Coupled", msg: {
           }
           on "Vehicle", "Decoupled", msg: {
           }
           on "Vehicle", "Derailed", msg: {
             if (msg.src == me) { status = CAR_DERAILED; break; }
           }
           on "World", "ModuleInit": {
             status = CarCheck();
             SetGear(status, GetDirectionRelativeToTrain());
           }
         }
         status = CarCheck();
       }
     }

   Bob Pearson

   I was thinking more generally about reskins and how to fix them up. Generally speaking the person who created the mesh and set the script up is unable to correct any reskins.

   Cheerio John

   ---

8. June 23rd, 2022, 07:46 PM

   #8

   
   

   Originally Posted by RPearson
   

   …. So updating each individual script is a nightmare. …

   Bob Pearson

   Yes, as we found with those 2000+ Russian switches that all used the same rdsjunc.gs script. Fortunately, N3V stepped in to take on the problem.

   Even if N3V does manage to repair some of those code libraries there must be 100’s, if not 1000’s, of scripted assets on the DLS with latent problems.

   
   Paul
   

   ---

9. June 23rd, 2022, 07:50 PM

   #9

   
   

   Originally Posted by johnwhelan
   

   I was thinking more generally about reskins and how to fix them up. Generally speaking the person who created the mesh and set the script up is unable to correct any reskins.

   Cheerio John

   John,
   Is there a particular problem with reskins?

   The «standard» way of repairing reskins is using that small script to swap textures in the Init() method. That works ok but can be unreliable for LODed models and especially if, say, the lowest LOD model uses a different material

   
   Paul
   

   ---

10. June 23rd, 2022, 08:49 PM

    #10

    
    

    Originally Posted by pcas1986
    

    John,
    Is there a particular problem with reskins?

    The «standard» way of repairing reskins is using that small script to swap textures in the Init() method. That works ok but can be unreliable for LODed models and especially if, say, the lowest LOD model uses a different material

    Over the years a lot of my work has been reskinned. Then a new version of trainz comes out or even a service pack and the asset needs fixing. I can fix the originals but not the reskins which are under a different kuid. For script errors not having the script in the asset would at least help.

    Cheerio John

    ---

11. June 23rd, 2022, 09:09 PM

    #11

    
    

    pm’d majekear asking if i could change his script file. with the change to it as above.

    Modeling Ho scale on the cheap

    GT 730 8 Meg

    ---

12. June 23rd, 2022, 09:14 PM

    #12

    
    

    Originally Posted by johnwhelan
    

    … For script errors not having the script in the asset would at least help.

    Cheerio John

    That, I imagine, would need a completely new way of doing reskins.

    I’m not a fan of reskins and never have been. There are so many issues with them that I tend to ignore those broken reskins in the CRG list in favour of something worth fixing.

    
    Paul
    

    ---

13. June 24th, 2022, 07:48 PM

    #13

    
    

    fourteen……..first, I have not read all the post here to your posting. Any script used were not created by me. So I really can’t give you permission to edit. Also, in the description tag of the car’s config.txt file is indication of those who create any script used. However, most scripts were created to be used without restriction. So I would look in the config.txt file of the script being used to see if permission to edit is needed. As to me, I have basically zero script writing ability. Therefore, I am trusting in those responding here to help you with the problem. RPearson has posted here and he is currently the person who is helping with any script problems I need or encounter. If he can’t help, I do not know who can. Thanks for your interest in the Reefer.

    ---

14. June 24th, 2022, 09:26 PM

    #14

    
    

    thank you for resoponding. looked at the it, domt see anything about needing permission etc.

    Modeling Ho scale on the cheap

    GT 730 8 Meg

    ---

Posting Permissions

Contents

• 1 class Crossing
  • 1.1 SetCrossingAutomatic()
  • 1.2 SetCrossingState()
• 2 class HTMLWindow
  • 2.1 GetCompleteIndustryViewDetailsHTMLCode()
• 3 class IndustryProductInfoCollection
  • 3.1 GetProductIndexFromAsset()
  • 3.2 GetProcessIndexFromName()
  • 3.3 AddProduct()
• 4 class Train
  • 4.1 GetVelocity()
• 5 class Vehicle
  • 5.1 GetFacingRelativeToTrain()

• 
• Форум
• Новый TRAINZ
• Trainz: A New Era
• Создание и адаптация дополнений
• Обмен исправленным контентом для TANE и ТC19

1. 20.06.2015 10:36

   #1

   Обмен исправленным контентом для TANE и ТC19
   

   Аналог «Поиска куидов» и «Устранение ошибок в дополнениях» для Тани.
   Примеры запроса

   1. Нужны исправленные

   2. В *таком-то-контенте* ошибки: *такие-то-ошибки*
   Прошу поделится или помочь исправить : *ссылка на контент*

   ВНИМАНИЕ

   Пост закреплен. Читать всем входящим. Запросы, составленные криво, будут удаляться. Имейте уважение к тем, кто вам помогает.

   В этой теме спрашиваем недостающие куиды для TANE/ТС19/ТС22
   Пожалуйста, пишите используя тег «code», в строку и без пробелов,
   например:

   Код:

   <kuid:******:******>,<kuid:******:******>,<kuid:******:******>

   Список куидов должен быть написан через запятую, без пробелов.
   Для правильного форматирования списка используем программу Kuid Wizard
   Отформатированный список вставляем в сообщение, выделяем и используем тег code, эта кнопка выглядит так:
   
   Просматриваем сообщение с помощью кнопки «Предварительный просмотр», правим ошибки, и только потом нажимаем «Отправить». Куиды так же можно поискать на:

   

   и

   

   При показе скриншотов с расшифровкой ошибок — используем только английский язык игры! На русском языке ошибки отображаются некорректно, не усложняйте жизнь помогающим вам!

   Последний раз редактировалось Фёдор Александрович; 23.02.2022 в 13:26.

   Трамвайники всіх країн єднайтеся!

   ---

2. 

   Сказал спасибо:

   ---

3. 20.06.2015 10:36

   #Trainz

   
   Реклама
   

   

   ---

   ---

4. 21.12.2018 08:22

   #431

   
   

   модулятор,

   

   Мой путь неизведан, он в бездне туманной…

   ---

5. 

   Сказали спасибо: (2)

   ---

6. 23.12.2018 13:18

   #432

   
   

   z7_station_controller

   Код:

   <kuid2:236443:9102428:1>

   В SP1 он был нормальный, а теперь синтаксическая ошибка, хотя в скрипте ничего не изменилось. 50 маршрутов стали красными. Удар в самое сердце!

   Код:

   - <kuid2:236443:9102428:1> VE197: Syntax error in script 'z7a_scontroller.gs' for asset <kuid2:236443:9102428:1> "z7_station_controller"
   - <kuid2:236443:9102428:1> TrainzBaseSpec::CacheScripts> ** GSC> z7a_scontroller.gs(293) : return type mismatch, expecting object[], line 293.
   - <kuid2:236443:9102428:1> z7a_scontroller.gs(293) : return type mismatch, expecting object[], line 293.

   ———- Сообщение добавлено в 15:18 ———- Предыдущее сообщение размещено в 11:41 ———-

   Код:

   <kuid2:117140:10137:5>

   Есть на ДЛС.
   Ничего не пойму. Там ещё с алиасами так напутано, что сам чёрт ногу сломит.

   Последний раз редактировалось Arix; 23.12.2018 в 09:43.

   Береги assets.tdx смолоду!

   ---

7. 23.12.2018 14:13

   #433

   
   

   Сообщение от Arix
   

   В SP1 он был нормальный, а теперь синтаксическая ошибка, хотя в скрипте ничего не изменилось. 50 маршрутов стали красными. Удар в самое сердце!

   В скрипте-то не изменилось, а вот в отношении к скрипту — да. Да и вообще какой смысл в TANE использовать архаичную Z7. Она же там практически неиграбельна. Я лично последний раз её в TANE видел в одной из ранних версий TANE-вского «Крыма» И уже в версии 3.7 маршрутизация отказала полностью. Выходов я вижу три: 1- не использовать карты с Z7 в TANE SP3(самое правильное имхо), 2- оставить для таких карт SP1, если уж так хочется их видеть в TANE, 3 — просить скриптёров подкорректировать скрипт станционного контроллера, но сильно сомневаюсь, что кто-то этим будет заниматься.———- Сообщение добавлено в 15:13 ———- Предыдущее сообщение размещено в 14:54 ———-

   Сообщение от Arix
   

   Есть на ДЛС.
   Ничего не пойму. Там ещё с алиасами так напутано, что сам чёрт ногу сломит.

   Алиас-объект не отображается в зависимостях, но наличие его, как и любой другой зависимости обязательно. Ты вообще алиас-объект этот загрузил и установил или нет? Вот этот самый ассет(последняя версия) Coal Mine Basic,<kuid:-25:1091> Без него естественно работать не будет.

   Последний раз редактировалось Фёдор Александрович; 23.12.2018 в 14:36.

   Мой путь неизведан, он в бездне туманной…

   ---

8. 23.12.2018 17:12

   #434

   
   

   Красные куиды.
   T:ANE

   Код:

   <kuid:346926:2011996>,<kuid:346926:2011997>,<kuid:346926:2011998>

   ---

9. 23.12.2018 18:14

   #435

   
   

   Сообщение от Фёдор Александрович
   

   Алиас-объект не отображается в зависимостях, но наличие его, как и любой другой зависимости обязательно. Ты вообще алиас-объект этот загрузил и установил или нет? Вот этот самый ассет(последняя версия) Coal Mine Basic, Без него естественно работать не будет.

   Установлен. В зависимостях отображается. Но <kuid2:117140:10137:5> Coal Mine Basic ссылается на <kuid:-3:10137> Coal Mine Basic. А он устаревший, его обсолетит <kuid:-25:1091>. Вот я и запутался. Может, и игра путается? Но я в конфиге у <kuid2:117140:10137:5> вписывал напрямую <kuid:-25:1091>, не помогает. Меши, вроде, все на месте. СМ пишет что-то про Reskin.

   Код:

   - <kuid2:117140:10137:5> MeshObjectSpec::LinkSpecs> Reskin does not match parent <kuid:-3:10137>

   

   Береги assets.tdx смолоду!

   ---

10. 23.12.2018 18:37

    #436

    
    

    2 часть.

    Код:

    <kuid:145747:22000>,<kuid:145747:22024>,<kuid:146087:23580>,<kuid:146087:23582>,<kuid:146087:23583>,<kuid:1794779:250201>,<kuid:211305:280015>,<kuid:346926:2011922>,<kuid:346926:2011923>,<kuid:477489:1305>,<kuid:477489:1307>,<kuid:9999:921555>,<kuid2:149987:37683:1>,<kuid2:151900:100202:1>,<kuid2:151900:100249:5>,<kuid2:151900:100250:2>,<kuid2:151900:500508:1>,<kuid2:151900:500512:1>,<kuid2:151900:500516:1>,<kuid2:346926:3401:3>,<kuid2:346926:3403:3>

    3 часть.

    Код:

    <kuid:121826:20019>,<kuid:239173:100063>,<kuid:303030:2036>,<kuid:303030:2037>,<kuid:35412:28012>,<kuid:70274:92003>,<kuid:81596:25104>,<kuid2:151900:500527:1>,<kuid2:151900:500529:1>,<kuid2:69084:38023:2>

    T:ANE

    ---

11. 24.12.2018 07:54

    #437

    
    

    Сообщение от FILIPP1992
    

    Красные куиды.
    T:ANE

    

    Мой путь неизведан, он в бездне туманной…

    ---

12. 

    Сказали спасибо: (2)

    ---

13. 26.12.2018 17:48

    #438

    
    

    Код:

    <kuid:370528:1179>,<kuid:370528:1214>,<kuid:370528:1230>,<kuid:370528:1245>,<kuid2:370528:1328:1>

    T:ANE

    ---

14. 27.12.2018 09:02

    #439

    
    

    FILIPP1992,

    

    Мой путь неизведан, он в бездне туманной…

    ---

15. 

    Сказали спасибо: (2)

    ---

16. 29.12.2018 13:49

    #440

    
    

    Код:

    <kuid:118606:140895>,<kuid:118606:141137>,<kuid:118606:141228>,<kuid:198708:113>,<kuid:201563:29045>,<kuid:279498:1009>,<kuid:343316:2791>,<kuid:450244:1009>,<kuid2:476056:1045:1>

    T:ANE
    2 часть.

    Последний раз редактировалось FILIPP1992; 29.12.2018 в 13:51.

    ---

Ваши права

if [[ $(bc <<< "$p0value > $freezeMax") ]]; then
        vP0='<a href="f1.php" class="blink">[Freezer 1: '
        vP0=$vP0$p0value
        vP0="$vP0 &deg;C]</a>"
        tempDIFF=$( bc <<< "$p0value-$freezeMax")
        echo "$P0_name is currently at $p0value °C, which is $tempDIFF °C higher than it should be. Please attend to this." >> $emailPATH/email.txt
        sendP0=1
elif [[ $(bc <<< "$p0value < $freezeMin") ]]; then
        vP0='<a href="f1.php" class="blink">[Freezer 1: '
        vP0=$vP0$p0value
        vP0="$vP0 &deg;C]</a>"
        tempDIFF=$(bc <<< "$freezeMin-$p0value")
        echo "$P0_name is currently at $p0value °C, which is $tempDIFF °C lower than it should be. Please attend to this." >> $emailPATH/email.txt
        sendP0=1
else
        vP0='<a href="f1.php" class="steady">[Freezer 1: '
        vP0=$vP0$p0value
        vP0="$vP0 &deg;C]</a>"
        sendP0=0
fi

4